Fix AND and OR operators #9
Conversation
There were mistakes on multiple levels, e.g. the scanner returning the wrong operator symbols for & and |, the parser not adding the correct functions to the tree and the implementation of the bitwise AND/OR operators (| and &) were completely missing.
projectm-eval/TreeFunctions.c
Outdated
| { "/*or*/", prjm_eval_func_or, 2, true, false }, | ||
| { "/*and*/", prjm_eval_func_and, 2, true, false }, |
There was a problem hiding this comment.
Using the special "comment" syntax here as ns-eel2 doesn't have any internal name for these two operator implementations. Since the scanner will skip over comments, this text can never occur as a function token in the parser and thus doesn't influence the syntax in any way.
Yeah, said this to Incubo as well, that's definitely one of the reasons this mixup occurred, as the naming was done by the Milkdrop authors and is even worse in the original code - especially as the implementations are pure assembly, so it's not overly obvious what the functions actually do. We could rename the internal implementations though, but the I'll rename the functions so the code gets more readable. |
2 participants
There were mistakes on multiple levels:
&and||and&) were completely missingAlready bumped the version to 1.0.2 in preparation of a new bugfix release.
Thanks to OfficialIncubo for finding this issue!